arturobernalg commented on code in PR #512:
URL:
https://github.com/apache/httpcomponents-core/pull/512#discussion_r1910396900
##########
httpcore5/src/main/java/org/apache/hc/core5/util/Deadline.java:
##########
@@ -83,8 +83,11 @@ public class Deadline {
*/
public static Deadline calculate(final long timeMillis, final TimeValue
timeValue) {
if (TimeValue.isPositive(timeValue)) {
- // TODO handle unlikely overflow
- final long deadline = timeMillis + timeValue.toMilliseconds();
+ final long timeToAdd = timeValue.toMilliseconds();
Review Comment:
@ok2c Updated the implementation as suggested. Thanks for the feedback!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
