ok2c commented on code in PR #660:
URL:
https://github.com/apache/httpcomponents-client/pull/660#discussion_r2206653112
##########
httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/HttpClientBuilder.java:
##########
@@ -211,6 +215,7 @@ private ExecInterceptorEntry(
private BackoffManager backoffManager;
private Lookup<AuthSchemeFactory> authSchemeRegistry;
private Lookup<CookieSpecFactory> cookieSpecRegistry;
+ @Deprecated
private LinkedHashMap<String, InputStreamFactory> contentDecoderMap;
Review Comment:
@arturobernalg I found an issue with this change-set that is easily fixable.
At the moment the `contentDecoderMap` variable is essentially write-only.
There is a non-deprecated setter for it but it is not being read anywhere. That
is wrong.
What needs to be done is this: `contentDecoderMap` must be removed, the
`#setContentDecoderRegistry` setter must be changed to populate
`contentDecoder` through an adaptor (see `DefaultHttpClientConnectionOperator`
for an example ) and the `#setContentDecoderRegistry` must be deprecated.
`contentDecoder` also sounds like a rather bad choice of a name for what is
essentially a map of objects
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
