ok2c commented on code in PR #680:
URL:
https://github.com/apache/httpcomponents-client/pull/680#discussion_r2215809120
##########
httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/HttpClientBuilder.java:
##########
@@ -838,6 +839,11 @@ protected Function<HttpContext, HttpClientContext>
contextAdaptor() {
}
public CloseableHttpClient build() {
+
Review Comment:
@arturobernalg I am a bit unsure HttpClient should be meddling with system
variables behind the scene. This can really have unexpected side-effects. Could
we document `EnvironmentProxyConfigurer` in javadocs and advise the users to
explicitly call `EnvironmentProxyConfigurer#apply` in order to carry over proxy
config from the runtime environment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
