arturobernalg commented on code in PR #680:
URL:
https://github.com/apache/httpcomponents-client/pull/680#discussion_r2216032226
##########
httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/HttpClientBuilder.java:
##########
@@ -838,6 +839,11 @@ protected Function<HttpContext, HttpClientContext>
contextAdaptor() {
}
public CloseableHttpClient build() {
+
Review Comment:
@ok2c Oleg, one last thought before I push: would you prefer we gate the
transfer behind a dedicated env-flag, e.g. `hc5_apply_proxy_env=true` so users
who really want the mapping can simply set it and skip the
explicit `EnvironmentProxyConfigurer.apply()` call?
Default remains “do nothing unless asked”
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
