ok2c commented on PR #709: URL: https://github.com/apache/httpcomponents-client/pull/709#issuecomment-3217986687
> Currently, this class seems to be exposing a serious bug in the HTTP/2 client. @rschmitt Curiously enough I am unable to reproduce the problem. I have run the test suite with the `#testRapidSequentialRequests` enabled against the latest core master and client master and all tests pass ``` h2: Validation disabled: Sequential requests (slow): 5 succeeded; 5 failed (50.00% success rate, 50.00% retriable) h2: Validation enabled: Sequential requests (slow): 10 succeeded; 0 failed (100.00% success rate) h2: Validation disabled: Sequential requests (rapid): 2,499 succeeded; 1 failed (99.96% success rate, 0.04% retriable) h2: Validation enabled: Sequential requests (rapid): 2,500 succeeded; 0 failed (100.00% success rate) h2: Validation disabled: Single large batch: 15 succeeded; 15 failed (50.00% success rate, 50.00% retriable) h2: Validation enabled: Single large batch: 30 succeeded; 0 failed (100.00% success rate) h2: Validation disabled: Multiple small batches: 8 succeeded; 7 failed (53.33% success rate, 46.67% retriable) h2: Validation enabled: Multiple small batches: 15 succeeded; 0 failed (100.00% success rate) h2c: Validation disabled: Sequential requests (slow): 5 succeeded; 5 failed (50.00% success rate, 50.00% retriable) h2c: Validation enabled: Sequential requests (slow): 10 succeeded; 0 failed (100.00% success rate) h2c: Validation disabled: Sequential requests (rapid): 2,500 succeeded; 0 failed (100.00% success rate) h2c: Validation enabled: Sequential requests (rapid): 2,500 succeeded; 0 failed (100.00% success rate) h2c: Validation disabled: Single large batch: 15 succeeded; 15 failed (50.00% success rate, 50.00% retriable) h2c: Validation enabled: Single large batch: 30 succeeded; 0 failed (100.00% success rate) h2c: Validation disabled: Multiple small batches: 8 succeeded; 7 failed (53.33% success rate, 46.67% retriable) h2c: Validation enabled: Multiple small batches: 15 succeeded; 0 failed (100.00% success rate) https: Validation disabled: Sequential requests (slow): 5 succeeded; 5 failed (50.00% success rate, 30.00% retriable) https: Validation enabled: Sequential requests (slow): 5 succeeded; 5 failed (50.00% success rate, 50.00% retriable) https: Validation disabled: Sequential requests (rapid): 2,392 succeeded; 108 failed (95.68% success rate, 4.28% retriable) https: Validation enabled: Sequential requests (rapid): 2,457 succeeded; 43 failed (98.28% success rate, 1.72% retriable) https: Validation disabled: Single large batch: 15 succeeded; 15 failed (50.00% success rate, 46.67% retriable) https: Validation enabled: Single large batch: 15 succeeded; 15 failed (50.00% success rate, 50.00% retriable) https: Validation disabled: Multiple small batches: 8 succeeded; 7 failed (53.33% success rate, 46.67% retriable) https: Validation enabled: Multiple small batches: 8 succeeded; 7 failed (53.33% success rate, 46.67% retriable) http: Validation disabled: Sequential requests (slow): 10 succeeded; 0 failed (100.00% success rate) http: Validation enabled: Sequential requests (slow): 10 succeeded; 0 failed (100.00% success rate) http: Validation disabled: Sequential requests (rapid): 2,066 succeeded; 434 failed (82.64% success rate, 17.24% retriable) http: Validation enabled: Sequential requests (rapid): 2,304 succeeded; 196 failed (92.16% success rate, 7.72% retriable) http: Validation disabled: Single large batch: 15 succeeded; 15 failed (50.00% success rate, 0.00% retriable) http: Validation enabled: Single large batch: 15 succeeded; 15 failed (50.00% success rate, 0.00% retriable) http: Validation disabled: Multiple small batches: 10 succeeded; 5 failed (66.67% success rate, 0.00% retriable) http: Validation enabled: Multiple small batches: 10 succeeded; 5 failed (66.67% success rate, 0.00% retriable) ``` I was also unable to reproduce the problem with the latest core 5.3.x and the latest client 5.5.x. ``` h2: Validation disabled: Sequential requests (slow): 5 succeeded; 5 failed (50.00% success rate, 50.00% retriable) h2: Validation enabled: Sequential requests (slow): 10 succeeded; 0 failed (100.00% success rate) h2: Validation disabled: Sequential requests (rapid): 2,500 succeeded; 0 failed (100.00% success rate) h2: Validation enabled: Sequential requests (rapid): 2,500 succeeded; 0 failed (100.00% success rate) h2: Validation disabled: Single large batch: 15 succeeded; 15 failed (50.00% success rate, 50.00% retriable) h2: Validation enabled: Single large batch: 30 succeeded; 0 failed (100.00% success rate) h2: Validation disabled: Multiple small batches: 8 succeeded; 7 failed (53.33% success rate, 46.67% retriable) h2: Validation enabled: Multiple small batches: 15 succeeded; 0 failed (100.00% success rate) h2c: Validation disabled: Sequential requests (slow): 10 succeeded; 0 failed (100.00% success rate) h2c: Validation enabled: Sequential requests (slow): 10 succeeded; 0 failed (100.00% success rate) h2c: Validation disabled: Sequential requests (rapid): 2,487 succeeded; 13 failed (99.48% success rate, 0.52% retriable) h2c: Validation enabled: Sequential requests (rapid): 2,500 succeeded; 0 failed (100.00% success rate) h2c: Validation disabled: Single large batch: 15 succeeded; 15 failed (50.00% success rate, 50.00% retriable) h2c: Validation enabled: Single large batch: 30 succeeded; 0 failed (100.00% success rate) h2c: Validation disabled: Multiple small batches: 10 succeeded; 5 failed (66.67% success rate, 33.33% retriable) h2c: Validation enabled: Multiple small batches: 15 succeeded; 0 failed (100.00% success rate) https: Validation disabled: Sequential requests (slow): 9 succeeded; 1 failed (90.00% success rate, 10.00% retriable) https: Validation enabled: Sequential requests (slow): 9 succeeded; 1 failed (90.00% success rate, 0.00% retriable) https: Validation disabled: Sequential requests (rapid): 1,432 succeeded; 1,068 failed (57.28% success rate, 42.36% retriable) https: Validation enabled: Sequential requests (rapid): 1,447 succeeded; 1,053 failed (57.88% success rate, 42.04% retriable) https: Validation disabled: Single large batch: 15 succeeded; 15 failed (50.00% success rate, 10.00% retriable) https: Validation enabled: Single large batch: 15 succeeded; 15 failed (50.00% success rate, 0.00% retriable) https: Validation disabled: Multiple small batches: 9 succeeded; 6 failed (60.00% success rate, 13.33% retriable) https: Validation enabled: Multiple small batches: 9 succeeded; 6 failed (60.00% success rate, 0.00% retriable) http: Validation disabled: Sequential requests (slow): 10 succeeded; 0 failed (100.00% success rate) http: Validation enabled: Sequential requests (slow): 10 succeeded; 0 failed (100.00% success rate) http: Validation disabled: Sequential requests (rapid): 2,286 succeeded; 214 failed (91.44% success rate, 8.52% retriable) http: Validation enabled: Sequential requests (rapid): 2,488 succeeded; 12 failed (99.52% success rate, 0.48% retriable) http: Validation disabled: Single large batch: 15 succeeded; 15 failed (50.00% success rate, 0.00% retriable) http: Validation enabled: Single large batch: 15 succeeded; 15 failed (50.00% success rate, 0.00% retriable) http: Validation disabled: Multiple small batches: 10 succeeded; 5 failed (66.67% success rate, 0.00% retriable) http: Validation enabled: Multiple small batches: 10 succeeded; 5 failed (66.67% success rate, 0.00% retriable) ``` It is entirely possible that https://github.com/apache/httpcomponents-core/commit/a202086dfa839076c597009731ebd05b4bddbd69 has fixed the cause of the problem but I am a bit doubtful. Could you please re-run the tests in your environment with the latest core master and let me know if the problem persists. In the meantime I will be working on improvement of the stale check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
