ok2c commented on code in PR #553:
URL:
https://github.com/apache/httpcomponents-core/pull/553#discussion_r2336313236
##########
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/AbstractH2StreamMultiplexer.java:
##########
@@ -1456,6 +1497,9 @@ public void push(final List<Header> headers, final
AsyncPushProducer pushProduce
ioSession.getLock().lock();
try {
+ if (countActiveLocalInitiated() >=
remoteConfig.getMaxConcurrentStreams()) {
Review Comment:
> > @arturobernalg so, the `MAX_CONCURRENT_STREAMS` does not apply to the
server pushed streams, as before?
>
> @ok2c You’re right to call this out. MAX_CONCURRENT_STREAMS does apply to
server-initiated streams. my bad
@arturobernalg You are trying to brute force a fix on an API that simply
does not have enough flexibility to support the protocol requirements. As I
said before a proper solution to this issue is not possible without an
extensive refactoring of the H2 protocol handling code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
