ok2c commented on PR #555: URL: https://github.com/apache/httpcomponents-core/pull/555#issuecomment-3284217955
@cdw8j 1. You need to make symmetric changes to `AsyncServerBootstrap` as well 2. Please add `@since 5.4` for all new public methods 3. Please give the method a better name. `#setLocalAuthResolver` is actually not a setter and `Auth` abbreviation is more customary for authentication rather than aurhority -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
