cdw8j commented on PR #556:
URL:
https://github.com/apache/httpcomponents-core/pull/556#issuecomment-3361960047
@ok2c Re-thinking this whole thing after it has been idling a bit in my
head, I wonder if it wouldn't actually make more sense to implement setter
methods in the `AsyncServerBootstrap` and `ServerBootstrap` classes for an
`authorityResolver` member that is passed to `RequestRouter.create()` and that
defaults to to the currently used
`RequestRouter.IGNORE_PORT_AUTHORITY_RESOLVER`. The application could then
choose to call `setAuthorityResolver(RequestRouter.LOCAL_AUTHORITY_RESOLVER)`
and `setCanonicalHostName("localhost")` to achieve the same behaviour as with
`useLocalAuthorityResolver(true)` according to the current proposal.
What do you think? Should I create a separate pull request for this option
and you decide which is preferrable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
