rschmitt commented on code in PR #789: URL: https://github.com/apache/httpcomponents-client/pull/789#discussion_r2701366763
########## httpclient5/src/main/java/org/apache/hc/client5/http/impl/IdleConnectionEvictor.java: ########## Review Comment: Another option is to rationalize `evictIdleConnections` and `ConnectionConfig.idleTimeout` in the client builders. The former could be used as the default value for the latter. This would provide a much stronger guarantee than my previous suggestion, which is still prone to race conditions since we don't have real-time guarantees about when `IdleConnectionEvictor` runs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
