[
https://issues.apache.org/jira/browse/HTTPCLIENT-2409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18054848#comment-18054848
]
Oleg Kalnichevski edited comment on HTTPCLIENT-2409 at 1/28/26 8:40 PM:
------------------------------------------------------------------------
> Considering that we are talking about `Content-Encoding` and
> `Content-Length`, we are not talking about hop-by-hop headers.
[~joakime] No, we are not talking about headers as such. We are talking about
your sweeping and factually wrong statement about the use of HttpClient in a
proxy scenario.
Now, as far as content headers are concerned the proxy MUST remove
`Content-Length` header from the origin response, if it chooses to use the
chunk coding for the next hop. Likewise, the proxy must drop or update
`Content-Encoding` and `Content-Length` headers if it chooses to automatically
decompress the origin response content.
Oleg
was (Author: olegk):
> Considering that we are talking about `Content-Encoding` and
> `Content-Length`, we are not talking about hop-by-hop headers.
[~joakime] No, we are not talking about headers as such. We are talking about
your sweeping and factually wrong statement about the use of HttpClient in a
proxy scenario.
Now, as far as content headers are concerned the proxy MUST remove
`Content-Length` header from the origin response, if it chooses to use the
chink coding for the next hop. Likewise, the proxy must drop or update
`Content-Encoding` and `Content-Length` if it chooses to automatically
decompress the origin response content.
Oleg
> Content-Length header not removed/modified when decompressing
> -------------------------------------------------------------
>
> Key: HTTPCLIENT-2409
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2409
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Affects Versions: 5.6
> Reporter: Cristian Vat
> Priority: Major
>
> When decompressing gzip or other compression schemes the Content-Length
> header is not modified/removed anymore as it was before, this can lead to
> unexpected behaviors like truncation depending on caller behavior.
>
> Originally thought it was a spring issue with RestClient as
> https://github.com/spring-projects/spring-framework/issues/36064
> Summary:
> * Content-Encoding: gzip
> * Content-Length: 9075
> * actual read content if reading fully: 56815
>
> It's a combination of Spring and HttpClient behaviors but it lead to
> truncation at the compressed content length.
> I checked JDK HttpClient and Jetty HttpClient and they remove the
> Content-Length header if doing decompression.
> The same seems to have been the case in HttpComponents HttpClient but then
> the code that removed the headers was removed on 20th October in
> [https://github.com/apache/httpcomponents-client/commit/56122fd33fb8a67d23369a81f6e1d89aabf4ba10]
> ?
>
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
