ok2c commented on code in PR #630:
URL:
https://github.com/apache/httpcomponents-core/pull/630#discussion_r2831879195
##########
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/ResponseConformance.java:
##########
@@ -63,12 +63,13 @@ public void process(final HttpResponse response, final
EntityDetails entity, fin
throws HttpException, IOException {
Args.notNull(response, "HTTP response");
final int status = response.getCode();
- switch (status) {
- case HttpStatus.SC_NO_CONTENT:
- case HttpStatus.SC_NOT_MODIFIED:
- if (entity != null) {
- throw new ProtocolException("Response " + status + " must
not enclose an entity");
- }
+ if (status >= 100 && status < 200
Review Comment:
@arturobernalg This is unnecessary. 1xx responses never get processed by the
protocol interceptors. Their life-cycle is completely separate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
