ok2c commented on PR #816: URL: https://github.com/apache/httpcomponents-client/pull/816#issuecomment-4226469705
@arturobernalg 1. Please use the async client because we want the REST client to support HTTP/2 as well. Please use it _without_ resorting to content buffering in memory (do not use 'simple' message objects). 'Simple' APIs are not intended for production use, so we should not be using them internally. Use the new Jackson2 bindings from core. 2. Please do not re-implement the percent codec. What stops you from using what we already have? Not good enough? Improve it. 3. Please use `URIBuilder` to construct request URIs. The whole thing still looks like it just got vibe-coded with some AI agent. There is no need to rush it. Take your time to do it right. I think this can be the most important contribution to the project since @rschmitt reactive module. So, _please_ take your time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
