ok2c commented on code in PR #781:
URL:
https://github.com/apache/httpcomponents-client/pull/781#discussion_r3294259087
##########
httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/AsyncCachingExec.java:
##########
@@ -98,13 +99,25 @@ class AsyncCachingExec extends CachingExecBase implements
AsyncExecChainHandler
private final HttpAsyncCache responseCache;
private final DefaultAsyncCacheRevalidator cacheRevalidator;
private final ConditionalRequestBuilder<HttpRequest>
conditionalRequestBuilder;
+ private final boolean requestCollapsingEnabled;
+ private final CacheRequestCollapser collapser;
AsyncCachingExec(final HttpAsyncCache cache, final
DefaultAsyncCacheRevalidator cacheRevalidator, final CacheConfig config) {
+ this(cache, cacheRevalidator, config, false);
+ }
+
+ AsyncCachingExec(
+ final HttpAsyncCache cache,
+ final DefaultAsyncCacheRevalidator cacheRevalidator,
+ final CacheConfig config,
+ final boolean requestCollapsingEnabled) {
Review Comment:
@arturobernalg I would move `requestCollapsingEnabled` to `CacheConfig` and
documented it being a hint. Some implementations (like async) may choose to
respect it, some may not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
