ok2c commented on PR #686:
URL:
https://github.com/apache/httpcomponents-core/pull/686#issuecomment-5159350994
> The build fails without this because Checkstyle sees the word "deprecated"
in the comment and wants a deprecated annotation I guess. It's lame but that's
what happens.
@garydgregory This is bizarre. This is what the check does. It should be
looking for `@deprecated` tag, not just a random occurrence of `deprecated`
text as far as I can tell. Once you have your change-set ready I will test it
locally with and without the `MissingDeprecated` check override.
```
@Override
public void visitJavadocToken(DetailNode ast) {
final DetailAST parentAst = getParent(getBlockCommentAst());
final boolean containsAnnotation =
AnnotationUtil.containsAnnotation(parentAst, DEPRECATED)
|| AnnotationUtil.containsAnnotation(parentAst, FQ_DEPRECATED);
final boolean containsJavadocTag = containsDeprecatedTag(ast);
if (containsAnnotation ^ containsJavadocTag) {
log(parentAst.getLineNo(),
MSG_KEY_ANNOTATION_MISSING_DEPRECATED);
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
