ok2c commented on code in PR #867:
URL:
https://github.com/apache/httpcomponents-client/pull/867#discussion_r3805533063
##########
httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/AsyncCachingExec.java:
##########
@@ -293,6 +300,15 @@ public void doExecute(
if (LOG.isDebugEnabled()) {
LOG.debug("{} request cannot be served from cache",
exchangeId);
}
+ // The cache lookup is bypassed here (non-cacheable method, or a
no-store / no-cache
+ // request), so no stored response was ever selected; this is not
fwd=request.
+ final String method = cacheRequest.getMethod();
+ final boolean cacheSupportedMethod = Method.GET.isSame(method)
Review Comment:
@arturobernalg Please make `CacheableRequestPolicy` and
`ResponseCachingPolicy` use this method as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
