ok2c commented on code in PR #690:
URL:
https://github.com/apache/httpcomponents-core/pull/690#discussion_r3838953722
##########
httpcore5/src/main/java/org/apache/hc/core5/reactor/SingleCoreIOReactor.java:
##########
@@ -349,8 +365,8 @@ private void processPendingConnectionRequests() {
if (!sessionRequest.isCancelled()) {
final SocketChannel socketChannel;
try {
- socketChannel =
openSocketFor(sessionRequest.remoteAddress);
- } catch (final IOException ex) {
+ socketChannel =
Args.notNull(socketChannelFactory.apply(sessionRequest.remoteAddress), "Socket
channel");
Review Comment:
@arturobernalg This looks odd. Why `Args#notNull` here? It is not an
argument and it is never `null`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
