ok2c commented on code in PR #713:
URL:
https://github.com/apache/httpcomponents-core/pull/713#discussion_r4172356923
##########
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/AbstractH2StreamMultiplexer.java:
##########
@@ -138,6 +138,9 @@ enum SettingsHandshake { READY, TRANSMITTED, ACKED }
private int lowMark;
private volatile H2Config remoteConfig;
+ private volatile int remoteHeaderTableSize;
Review Comment:
@arturobernalg Why do you need these variable at all? I do not get it. You
can still use their signed int representation from `H2Config` and convert it to
unsigned long only when doing some calculations.
##########
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/AbstractH2StreamMultiplexer.java:
##########
@@ -526,11 +532,6 @@ public final void onOutput() throws HttpException,
IOException {
if (connOutputWindow.get() > 0 && remoteSettingState ==
SettingsHandshake.ACKED) {
produceOutput();
- } else {
Review Comment:
@arturobernalg Please be careful. You are reverting changes from a previous
fix.
##########
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/AbstractH2StreamMultiplexer.java:
##########
@@ -1089,7 +1090,7 @@ private void consumeFrame(final RawFrame frame) throws
HttpException, IOExceptio
for (final Iterator<H2Stream> it = streams.iterator();
it.hasNext(); ) {
final H2Stream stream = it.next();
final int activeStreamId = stream.getId();
- if (streams.isSameSide(activeStreamId) &&
activeStreamId > processedLocalStreamId) {
+ if (!streams.isSameSide(activeStreamId) &&
activeStreamId > processedLocalStreamId) {
Review Comment:
@arturobernalg Please be careful. You are reverting changes from a previous
fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
