ok2c commented on code in PR #900:
URL:
https://github.com/apache/httpcomponents-client/pull/900#discussion_r4362233617
##########
httpclient5/src/main/java/org/apache/hc/client5/http/impl/cookie/RFC6265CookieSpec.java:
##########
@@ -236,8 +242,11 @@ public List<Header> formatCookies(final List<Cookie>
cookies) {
buffer.append(PARAM_DELIMITER);
buffer.append(' ');
}
- buffer.append(cookie.getName());
Review Comment:
@dxbjavid `#formatCookies` looks like the wrong place to throw
`IllegalArgumentException` and rather too late. Those cookies come from the
`CookieStore` of the caller and can be considered validated. What we can do
instead is filter non-printable characters out or replace with `?`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
