arturobernalg commented on PR #915: URL: https://github.com/apache/httpcomponents-client/pull/915#issuecomment-6542767356
> @arturobernalg Excellent findings! Thank you so much! > > > For /a/b/.., master returns /, whereas this change returns /a/b/ > > But this is wrong, is it not? It should be `/a/` should it not? I kept the existing behavior for now, but I think this has to be fixed > > > since / is not in UNRESERVED, the fast path is never taken for normal absolute paths. > > Corrected. Please do another pass. > But this is wrong, is it not? It should be `/a/` should it not? I kept the existing behavior for now, but I think this has to be fixed One remaining difference I noticed: consecutive slashes now bypass normalization. For /a//b, master returns /a/, while the new fast path returns /a//. this change intentional? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
