arturobernalg commented on PR #729: URL: https://github.com/apache/httpcomponents-core/pull/729#issuecomment-6556702120
> @arturobernalg I am strongly not in favor of this change. It adds an extra full scan over chunk length element. Either be pragmatic and test for leading char not being `-` or `+` or blank, or consider implementing a better `#parseLong` method @ok2c agreed. Updated. Removed the extra scan and added a leading-character check as suggested. The existing parsing and overflow handling remain unchanged. Please do another pass -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
