arturobernalg opened a new pull request, #735: URL: https://github.com/apache/httpcomponents-core/pull/735
StrictConnPool#enumAvailable() and #enumLeased() expire pending lease requests through processPendingRequests() but never fire the completion callbacks. The future of a request that timed out stays uncompleted until the next lease or release, so closeExpired() and closeIdle() do not enforce the lease request timeout on an otherwise idle pool. Both methods now call fireCallbacks() after releasing the lock, as validatePendingRequests() does. TestPoolPendingRequestExpiry checks closeExpired() and closeIdle() on all three pools. Only StrictConnPool failed before the change; LaxConnPool and RouteSegmentedConnPool already complete the future of an expired request. Raised in HTTPCLIENT-2437. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
