parker89 commented on code in PR #929:
URL:
https://github.com/apache/httpcomponents-client/pull/929#discussion_r4472700804
##########
httpclient5/src/test/java/org/apache/hc/client5/http/impl/classic/TestProtocolExec.java:
##########
@@ -75,19 +85,191 @@ class TestProtocolExec {
@Mock
private AuthenticationStrategy proxyAuthStrategy;
@Mock
+ private AuthCache authCache;
+ @Mock
private ExecChain chain;
@Mock
private ExecRuntime execRuntime;
+ private AtomicBoolean pathPrefixExtracted;
+ private Factory<HttpRequest, Supplier<String>> prefixExtractorFactory;
private ProtocolExec protocolExec;
private HttpHost target;
@BeforeEach
void setup() {
- protocolExec = new ProtocolExec(targetAuthStrategy, proxyAuthStrategy,
null, true);
+ pathPrefixExtracted = new AtomicBoolean();
+ prefixExtractorFactory = request -> () -> {
Review Comment:
Small thing, not blocking: since this replaces
`RequestSupport.pathPrefixSupplier`, the memoization never gets exercised.
Maybe a quick check in `TestRequestSupport` that calls `get()` twice on a
slow-path input like `/aaaa//bbbb` and does `assertSame`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
