Hi Rahul, IMHO we should take the pom-first approach. This will help keep our sanity in the long run of why a JAR is in our bundles. The newer components have like 30-50 JARs, and we will quickly lose track of versions and JAR dependency chains. We should invest time in creating proper pom.xml files. This also helps in keeping our source footprint small.
I have opened HDT-39 to provide this functionality. https://issues.apache.org/jira/browse/HDT-39. Best regards, Srimanth On Wed, Jul 31, 2013 at 8:15 PM, Rahul Sharma <[email protected]> wrote: > Hi Srimanth, > > When we build using maven and tycho, there are two ways to generate a > bundle. First is the manifest-first approach, where bundle is generated > using the Manifest in the project. Maven picks everything from the manifest > file and thus dependency resolutions and other things do not kick-in. The > second is pom-first approach, now in this manner all things are generated > via the pom and manifest file in project does not play much role. It is > generated at run-time. You can not mix the two approaches in the same > Reactor build. In HDT we have manifest-first approach and thus we need to > bundle libs, we already have an issue for the same[1]. Maybe I can spend > sometime to get pom first approach. > > regards, > Rahul > > [1]https://issues.apache.org/jira/browse/HDT-15 > > > On Thu, Aug 1, 2013 at 5:19 AM, Srimanth Gunturi <[email protected]> > wrote: > > > Hi Rahul, > > Maven should get the JARs dynamically right? > > I am wondering why the patch would be so large. What JARs are the > largest? > > Regards, > > Srimanth > > > > > > > > > > > > On Wed, Jul 31, 2013 at 8:09 AM, Rahul Sharma <[email protected]> > wrote: > > > > > Hi Devs, > > > > > > I have added Maven Tycho build to hadoop-eclipse-merge branch, but I > > would > > > like to get this patch reviewed by another pair of eyes. Unfortunately > > due > > > to libs also getting added the patch size is larger than what I can > > upload > > > to jira. The patch is about 17 MB in size. > > > Any suggestions ? > > > > > > regards > > > Rahul > > > > > >
