Hi Srimanth, In case of eclipse plugins things are driven by manifest.mf, so POM first is a an approach where we use POM file to generate manifest file.For POM first approach we use maven-bundle-plugin. In the other approach maven does not generate a manifest.mf and thus uses the one available in the src.
Eclipse PDE is a bit different from the java based projects. There are different files for varied things like plugin.xml, fragment.xml, category.xml etc. Testing this is a bit different in this environment. In order work with this in maven there is the tycho plugin [1] , also one maven-pde plugin [2] is there which can work with eclipse based development. I would like to drive dependencies from maven, this would decouple us from keeping libs in our src as we have done in current master. This also means things like classpath/manifest/settings will be generated via maven and no longer will be required in our src. But there are few limitations in the way tycho-maven works and thus some playing around is required get an optimal configuration that can work for as. I hope I am making some sense. I have taken my first stab at it and will post a patch on on HDT-39[3] regards Rahul [1]http://eclipse.org/tycho/ [2]http://mojo.codehaus.org/pde-maven-plugin/ [3]https://issues.apache.org/jira/browse/HDT-39 On Sun, Aug 4, 2013 at 5:30 AM, Srimanth Gunturi <[email protected]> wrote: > Hi Rahul, > I might have misunderstood the pom-first approach. > Please correct me if I am wrong, but it seems to require some manifest.mf > entries in the pom.xml itself. > If that is the case, then I think we should not use the pom-first approach > for our eclipse plugins. > > I was thinking of using maven for dynamically providing the dependency > libraries only. > That way we do have a clean record of dependencies. We could use the > copyDependencies to add to development time classpath. > Also, we do not have to checkin dependency libraries to git. > > I am trying to think if we really need to use tycho for building plugins? > Building plugins/features is a relatively straightforward process and am > hoping we can do it with regular maven. > Hoping that make sense. > Regards, > Srimanth > > > > > On Thu, Aug 1, 2013 at 12:04 AM, Srimanth Gunturi <[email protected] > >wrote: > > > Hi Rahul, > > IMHO we should take the pom-first approach. > > This will help keep our sanity in the long run of why a JAR is in our > > bundles. > > The newer components have like 30-50 JARs, and we will quickly lose track > > of versions and JAR dependency chains. > > We should invest time in creating proper pom.xml files. > > This also helps in keeping our source footprint small. > > > > I have opened HDT-39 to provide this functionality. > > https://issues.apache.org/jira/browse/HDT-39. > > Best regards, > > Srimanth > > > > > > > > > > On Wed, Jul 31, 2013 at 8:15 PM, Rahul Sharma <[email protected]> > wrote: > > > >> Hi Srimanth, > >> > >> When we build using maven and tycho, there are two ways to generate a > >> bundle. First is the manifest-first approach, where bundle is generated > >> using the Manifest in the project. Maven picks everything from the > >> manifest > >> file and thus dependency resolutions and other things do not kick-in. > The > >> second is pom-first approach, now in this manner all things are > generated > >> via the pom and manifest file in project does not play much role. It is > >> generated at run-time. You can not mix the two approaches in the same > >> Reactor build. In HDT we have manifest-first approach and thus we need > to > >> bundle libs, we already have an issue for the same[1]. Maybe I can spend > >> sometime to get pom first approach. > >> > >> regards, > >> Rahul > >> > >> [1]https://issues.apache.org/jira/browse/HDT-15 > >> > >> > >> On Thu, Aug 1, 2013 at 5:19 AM, Srimanth Gunturi <[email protected]> > >> wrote: > >> > >> > Hi Rahul, > >> > Maven should get the JARs dynamically right? > >> > I am wondering why the patch would be so large. What JARs are the > >> largest? > >> > Regards, > >> > Srimanth > >> > > >> > > >> > > >> > > >> > > >> > On Wed, Jul 31, 2013 at 8:09 AM, Rahul Sharma <[email protected]> > >> wrote: > >> > > >> > > Hi Devs, > >> > > > >> > > I have added Maven Tycho build to hadoop-eclipse-merge branch, but I > >> > would > >> > > like to get this patch reviewed by another pair of eyes. > Unfortunately > >> > due > >> > > to libs also getting added the patch size is larger than what I can > >> > upload > >> > > to jira. The patch is about 17 MB in size. > >> > > Any suggestions ? > >> > > > >> > > regards > >> > > Rahul > >> > > > >> > > >> > > > > >
