Github user kongweihan commented on a diff in the pull request:
https://github.com/apache/helix/pull/89#discussion_r115829596
--- Diff:
helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java
---
@@ -204,4 +236,28 @@ private MappingCalculator
getMappingCalculator(Rebalancer rebalancer, String res
return mappingCalculator;
}
+
+ class JobResourcePriority implements Comparable<JobResourcePriority> {
--- End diff --
I would name this differently. This object is not a "priority", but a job
resource _with_ priority. Maybe `JobResourceWithPriority`,
`ComparableJobResource` or just `JobResource` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
