[GitHub] helix pull request #200: throw new Exception to avoid ugly NPE

[zhan849]

Github user zhan849 commented on a diff in the pull request:

    https://github.com/apache/helix/pull/200#discussion_r185050120
  
    --- Diff: 
helix-core/src/main/java/org/apache/helix/tools/commandtools/ZkGrep.java ---
    @@ -463,9 +463,8 @@ static File gunzip(File zipFile) {
           return outputFile;
         } catch (IOException e) {
           LOG.error("fail to gunzip file: " + zipFile, e);
    +      throw new Exception("fail to gunzip file" + zipFile);
    --- End diff --
    
    yes.
    
    Tooling is fine here as NPE is caught outside, and proper error message are 
printed out.
    
    BTW, wrapping IOException using generic Exception will erase the proper 
semantics that IOException carries, which is not a good practice.


---