[GitHub] helix pull request #200: throw new Exception to avoid ugly NPE

[zhan849]

Github user zhan849 commented on a diff in the pull request:

    https://github.com/apache/helix/pull/200#discussion_r185911985
  
    --- Diff: 
helix-core/src/main/java/org/apache/helix/tools/commandtools/ZkGrep.java ---
    @@ -463,9 +463,8 @@ static File gunzip(File zipFile) {
           return outputFile;
         } catch (IOException e) {
           LOG.error("fail to gunzip file: " + zipFile, e);
    +      throw new Exception("fail to gunzip file" + zipFile);
    --- End diff --
    
    @lujiefsi might not be a good idea to only check lastZkSnapshot, because 
gunzip() is used in multiple places and you need to check all of them.


---