narendly commented on issue #353: Don't ignore exceptions: adding log messages to help check exceptions. URL: https://github.com/apache/helix/issues/353#issuecomment-513972958 Actually, we do not want to log anything here. 1. This exception does not actually signal that anything is wrong. It just means that the resource config read from ZK is not of the workflow type (not a WorkflowConfig). The inline comment says this. The code is essentially using a try-catch like an if-else clause if that makes sense. 2. Perhaps a better way to do this is by looking to see if the ZNRecord has a workflow-related field or not. This change could be made (using an if-else), but since the end result would be the same, so I would put this at a lower priority. It would be a style fix Hunter On Jul 22, 2019, 22:01, at 22:01, pkuwm <[email protected]> wrote: >Ex.: >https://github.com/apache/helix/blob/3e670ded2ece50e21b76fcab7fed7cb61a24eea1/helix-core/src/main/java/org/apache/helix/task/TaskDriver.java#L846 > >If you catch an exception, you may not want to ignore it. Adding a log >message would help engineers to understand what happens. > >-- >You are receiving this because you are subscribed to this thread. >Reply to this email directly or view it on GitHub: >https://github.com/apache/helix/issues/353
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
