narendly commented on issue #353: Don't ignore exceptions: adding log messages to help check exceptions. URL: https://github.com/apache/helix/issues/353#issuecomment-513988811 What you are saying makes sense. But for this exception specifically, we do not want to log it because it will pollute the log. Suppose you have an application that has a lot of non-workflow configs and just a few workflow configs. If the application calls getWorkflows () frequently, it will have a lot of redundant logs. This is a Helix internal detail we do not expose to the application. Does this make sense? - Hunter On Jul 23, 2019, 01:05, at 01:05, pkuwm <[email protected]> wrote: >Thanks for the explanation! I understand what the code is doing. If the >property is not a correct type, it continues to check next one. My idea >is if it is an exception, it should be handled properly, at least log >the info to indicate the property/key is not a workflow type so it >could be resolved. > >Anytime, the code above is just an example. There may be other places >don’t handle all the exceptions. I propose this to handle exceptions >properly. > >-- >You are receiving this because you commented. >Reply to this email directly or view it on GitHub: >https://github.com/apache/helix/issues/353#issuecomment-513987724
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
