> On Aug. 14, 2013, 10:14 p.m., Kishore Gopalakrishna wrote: > > helix-core/src/test/java/org/apache/helix/manager/zk/TestZkBaseDataAccessor.java, > > line 91 > > <https://reviews.apache.org/r/13581/diff/1/?file=341443#file341443line91> > > > > can we have a test case that reads the value along with stat and set > > it. why is that we return stat while reading but use int when writing. > > > > what happens if we read change the access option while writing, for > > example convert node from persistent to ephemeral and vice versa. Using > > stat should prevent that from happening, can we have a test case for this?
set() uses version# only. passing stat instead of version seems confusing. Agree with other changes. - Zhen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13581/#review25188 ----------------------------------------------------------- On Aug. 14, 2013, 9:52 p.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13581/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2013, 9:52 p.m.) > > > Review request for helix, Kanak Biscuitwala, Kishore Gopalakrishna, and Shi > Lu. > > > Repository: helix-git > > > Description > ------- > > Add support to set data with expect version in BaseDataAccessor > > > Diffs > ----- > > helix-core/src/main/java/org/apache/helix/BaseDataAccessor.java 7c65460 > > helix-core/src/main/java/org/apache/helix/manager/zk/ZkBaseDataAccessor.java > 77e2b5a > > helix-core/src/main/java/org/apache/helix/manager/zk/ZkCacheBaseDataAccessor.java > 869871c > helix-core/src/test/java/org/apache/helix/Mocks.java e30c09b > > helix-core/src/test/java/org/apache/helix/manager/zk/TestZkBaseDataAccessor.java > f97e018 > > Diff: https://reviews.apache.org/r/13581/diff/ > > > Testing > ------- > > > Thanks, > > Zhen Zhang > >
