----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13581/#review25259 -----------------------------------------------------------
Ship it! Looks good - Kishore Gopalakrishna On Aug. 15, 2013, 11:22 p.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13581/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2013, 11:22 p.m.) > > > Review request for helix, Kanak Biscuitwala, Kishore Gopalakrishna, and Shi > Lu. > > > Repository: helix-git > > > Description > ------- > > Add support to set data with expect version in BaseDataAccessor > > > Diffs > ----- > > helix-core/src/main/java/org/apache/helix/BaseDataAccessor.java 7c65460 > helix-core/src/main/java/org/apache/helix/manager/zk/HelixGroupCommit.java > 6de5d82 > > helix-core/src/main/java/org/apache/helix/manager/zk/ZkBaseDataAccessor.java > 77e2b5a > > helix-core/src/main/java/org/apache/helix/manager/zk/ZkCacheBaseDataAccessor.java > 869871c > helix-core/src/test/java/org/apache/helix/Mocks.java e30c09b > > helix-core/src/test/java/org/apache/helix/manager/zk/TestZkBaseDataAccessor.java > f97e018 > > Diff: https://reviews.apache.org/r/13581/diff/ > > > Testing > ------- > > > Thanks, > > Zhen Zhang > >
