----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13696/ -----------------------------------------------------------
Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu. Bugs: HELIX-174 Repository: helix-git Description ------- Fix for HELIX-174. The current ideal state calculators assume master-slave and are in the tools package. The tools package should call Helix routines, and not vice-versa. Some of the calculators can work for models other than master-slave, so they shouldn't assume master-slave anywhere. Diffs ----- helix-core/src/main/java/org/apache/helix/controller/strategy/ConsistentHashingMasterSlaveStrategy.java PRE-CREATION helix-core/src/main/java/org/apache/helix/controller/strategy/DefaultTwoStateStrategy.java PRE-CREATION helix-core/src/main/java/org/apache/helix/controller/strategy/EspressoRelayStrategy.java PRE-CREATION helix-core/src/main/java/org/apache/helix/controller/strategy/RUSHMasterSlaveStrategy.java PRE-CREATION helix-core/src/main/java/org/apache/helix/controller/strategy/RUSHrHash.java PRE-CREATION helix-core/src/main/java/org/apache/helix/controller/strategy/ShufflingTwoStateStrategy.java PRE-CREATION helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java a9226d3 helix-core/src/main/java/org/apache/helix/tools/DefaultIdealStateCalculator.java 3c63269 helix-core/src/main/java/org/apache/helix/tools/IdealCalculatorByConsistentHashing.java c630e75 helix-core/src/main/java/org/apache/helix/tools/IdealStateCalculatorByRush.java efa9f90 helix-core/src/main/java/org/apache/helix/tools/IdealStateCalculatorByShuffling.java 06ba715 helix-core/src/main/java/org/apache/helix/tools/IdealStateCalculatorForEspressoRelay.java 000a013 helix-core/src/main/java/org/apache/helix/tools/RUSHrHash.java da3dd74 helix-core/src/main/java/org/apache/helix/util/RebalanceUtil.java 03c45c4 helix-core/src/test/java/org/apache/helix/TestEspressoStorageClusterIdealState.java 6634175 helix-core/src/test/java/org/apache/helix/TestRelayIdealStateCalculator.java 8ecfc69 helix-core/src/test/java/org/apache/helix/TestShuffledIdealState.java 881bf5c helix-core/src/test/java/org/apache/helix/controller/stages/TestCompatibilityCheckStage.java d7de733 helix-core/src/test/java/org/apache/helix/controller/stages/TestResourceComputationStage.java 71013a1 helix-core/src/test/java/org/apache/helix/controller/strategy/TestEspressoRelayStrategy.java PRE-CREATION helix-core/src/test/java/org/apache/helix/controller/strategy/TestEspressoStorageClusterIdealState.java PRE-CREATION helix-core/src/test/java/org/apache/helix/controller/strategy/TestShufflingTwoStateStrategy.java PRE-CREATION helix-core/src/test/java/org/apache/helix/integration/TestAutoIsWithEmptyMap.java d05a288 helix-core/src/test/java/org/apache/helix/integration/TestDriver.java 63009fd helix-core/src/test/java/org/apache/helix/integration/TestExpandCluster.java 56feb76 helix-core/src/test/java/org/apache/helix/integration/TestRenamePartition.java fe0cbc9 helix-core/src/test/java/org/apache/helix/josql/TestClusterJosqlQueryProcessor.java 3b8d29c helix-core/src/test/java/org/apache/helix/messaging/TestDefaultMessagingService.java d99ee2f helix-core/src/test/java/org/apache/helix/monitoring/mbeans/TestClusterStatusMonitor.java 68cbaac helix-core/src/test/java/org/apache/helix/monitoring/mbeans/TestResourceMonitor.java 9d50d51 Diff: https://reviews.apache.org/r/13696/diff/ Testing ------- Tests passing locally. Thanks, Kanak Biscuitwala
