----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13696/#review25574 -----------------------------------------------------------
Ship it! Ship It! - Kishore Gopalakrishna On Aug. 26, 2013, 7:38 p.m., Kanak Biscuitwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13696/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2013, 7:38 p.m.) > > > Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu. > > > Bugs: HELIX-174 > > > Repository: helix-git > > > Description > ------- > > Fix for HELIX-174. The current ideal state calculators assume master-slave > and are in the tools package. The tools package should call Helix routines, > and not vice-versa. Some of the calculators can work for models other than > master-slave, so they shouldn't assume master-slave anywhere. > > > Diffs > ----- > > > helix-core/src/main/java/org/apache/helix/controller/strategy/ConsistentHashingMasterSlaveStrategy.java > PRE-CREATION > > helix-core/src/main/java/org/apache/helix/controller/strategy/DefaultTwoStateStrategy.java > PRE-CREATION > > helix-core/src/main/java/org/apache/helix/controller/strategy/EspressoRelayStrategy.java > PRE-CREATION > > helix-core/src/main/java/org/apache/helix/controller/strategy/RUSHMasterSlaveStrategy.java > PRE-CREATION > > helix-core/src/main/java/org/apache/helix/controller/strategy/RUSHrHash.java > PRE-CREATION > > helix-core/src/main/java/org/apache/helix/controller/strategy/ShufflingTwoStateStrategy.java > PRE-CREATION > helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java > 08a8208 > > helix-core/src/main/java/org/apache/helix/tools/DefaultIdealStateCalculator.java > dea8e0a > > helix-core/src/main/java/org/apache/helix/tools/IdealCalculatorByConsistentHashing.java > 1101a6d > > helix-core/src/main/java/org/apache/helix/tools/IdealStateCalculatorByRush.java > 7677b42 > > helix-core/src/main/java/org/apache/helix/tools/IdealStateCalculatorByShuffling.java > d4764ef > > helix-core/src/main/java/org/apache/helix/tools/IdealStateCalculatorForEspressoRelay.java > 25ae625 > helix-core/src/main/java/org/apache/helix/tools/RUSHrHash.java fb9c594 > helix-core/src/main/java/org/apache/helix/tools/YAISCalculator.java 4292baa > helix-core/src/main/java/org/apache/helix/util/RebalanceUtil.java 3f8c406 > > helix-core/src/test/java/org/apache/helix/TestEspressoStorageClusterIdealState.java > 9b249ec > > helix-core/src/test/java/org/apache/helix/TestRelayIdealStateCalculator.java > ca58659 > helix-core/src/test/java/org/apache/helix/TestShuffledIdealState.java > 5c158f8 > > helix-core/src/test/java/org/apache/helix/controller/stages/TestCompatibilityCheckStage.java > 391d1af > > helix-core/src/test/java/org/apache/helix/controller/stages/TestResourceComputationStage.java > dcb955c > > helix-core/src/test/java/org/apache/helix/controller/strategy/TestEspressoRelayStrategy.java > PRE-CREATION > > helix-core/src/test/java/org/apache/helix/controller/strategy/TestEspressoStorageClusterIdealState.java > PRE-CREATION > > helix-core/src/test/java/org/apache/helix/controller/strategy/TestShufflingTwoStateStrategy.java > PRE-CREATION > > helix-core/src/test/java/org/apache/helix/integration/TestAutoIsWithEmptyMap.java > 1ffb86f > helix-core/src/test/java/org/apache/helix/integration/TestDriver.java > 951607b > > helix-core/src/test/java/org/apache/helix/integration/TestExpandCluster.java > a9aa3b9 > > helix-core/src/test/java/org/apache/helix/integration/TestRenamePartition.java > ed056ab > > helix-core/src/test/java/org/apache/helix/josql/TestClusterJosqlQueryProcessor.java > 8090201 > > helix-core/src/test/java/org/apache/helix/messaging/TestDefaultMessagingService.java > 9686e16 > > helix-core/src/test/java/org/apache/helix/monitoring/mbeans/TestClusterStatusMonitor.java > 711aff2 > > helix-core/src/test/java/org/apache/helix/monitoring/mbeans/TestResourceMonitor.java > d631dd2 > > Diff: https://reviews.apache.org/r/13696/diff/ > > > Testing > ------- > > Tests passing locally. > > > Thanks, > > Kanak Biscuitwala > >
