----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14704/ -----------------------------------------------------------
(Updated Oct. 17, 2013, 10:08 a.m.) Review request for helix, Zhen Zhang and Kishore Gopalakrishna. Changes ------- Refactored validation logic into a separate class Bugs: HELIX-144 Repository: helix-git Description ------- commit 1144384696cb3a0e5acc061380b2c78f1700dcfc Author: Kanak Biscuitwala <[email protected]> Date: Wed Oct 16 18:06:58 2013 -0700 [HELIX-144] Validate StateModelDefinition before adding it to the cluster :100644 100644 025402d... 94e8feb... M helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixDataAccessor.java :100644 100644 7f08b6f... 5300eb2... M helix-core/src/main/java/org/apache/helix/model/StateModelDefinition.java :000000 100644 0000000... 2e4d5f0... A helix-core/src/test/java/org/apache/helix/model/TestStateModelValidity.java :100644 100644 cb51be9... e9a79d3... M src/site/markdown/tutorial_state.md Diffs (updated) ----- helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixDataAccessor.java 025402d helix-core/src/main/java/org/apache/helix/model/StateModelDefinition.java 7f08b6f helix-core/src/main/java/org/apache/helix/model/util/StateModelDefinitionValidator.java PRE-CREATION helix-core/src/test/java/org/apache/helix/model/TestStateModelValidity.java PRE-CREATION src/site/markdown/tutorial_state.md cb51be9 Diff: https://reviews.apache.org/r/14704/diff/ Testing ------- Added some new tests to make sure that old models still work and erroneous ones are caught. Thanks, Kanak Biscuitwala
