----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14931/#review27547 -----------------------------------------------------------
helix-core/src/main/java/org/apache/helix/controller/rebalancer/AutoRebalancer.java <https://reviews.apache.org/r/14931/#comment53467> it will be helpful to see the tag name in the message. It probably better to have a warn message if one cannot find any tagged live instances. - Kishore Gopalakrishna On Oct. 25, 2013, 5:20 p.m., Kanak Biscuitwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14931/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2013, 5:20 p.m.) > > > Review request for helix, Zhen Zhang and Kishore Gopalakrishna. > > > Bugs: HELIX-280 > > > Repository: helix-git > > > Description > ------- > > commit 4f3540695ec6b65c7eb745fb5cbdb1debccb5fe6 > Author: Kanak Biscuitwala <[email protected]> > Date: Fri Oct 25 09:46:57 2013 -0700 > > [HELIX-280] Full auto rebalancer should check resource tag first > > :100644 100644 3eb258b... 7da3506... M > helix-core/src/main/java/org/apache/helix/controller/rebalancer/AutoRebalancer.java > :100644 100644 d815c80... e0c8b6f... M > helix-core/src/test/java/org/apache/helix/integration/TestFullAutoNodeTagging.java > > > Diffs > ----- > > > helix-core/src/main/java/org/apache/helix/controller/rebalancer/AutoRebalancer.java > 3eb258b > > helix-core/src/test/java/org/apache/helix/integration/TestFullAutoNodeTagging.java > d815c80 > > Diff: https://reviews.apache.org/r/14931/diff/ > > > Testing > ------- > > Existing tests pass, new test passes. > > > Thanks, > > Kanak Biscuitwala > >
