----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14931/#review27571 -----------------------------------------------------------
helix-core/src/main/java/org/apache/helix/controller/rebalancer/AutoRebalancer.java <https://reviews.apache.org/r/14931/#comment53510> Lets not mix app logic and logging level check. More than taggedLiveNodes, we need to warn user if we don't find any node added with that tag. Think of the scenario where idealstate has a tag but none of the nodes added to the cluster have that tag - Kishore Gopalakrishna On Oct. 25, 2013, 9:16 p.m., Kanak Biscuitwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14931/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2013, 9:16 p.m.) > > > Review request for helix, Zhen Zhang and Kishore Gopalakrishna. > > > Bugs: HELIX-280 > > > Repository: helix-git > > > Description > ------- > > commit 4f3540695ec6b65c7eb745fb5cbdb1debccb5fe6 > Author: Kanak Biscuitwala <[email protected]> > Date: Fri Oct 25 09:46:57 2013 -0700 > > [HELIX-280] Full auto rebalancer should check resource tag first > > :100644 100644 3eb258b... 7da3506... M > helix-core/src/main/java/org/apache/helix/controller/rebalancer/AutoRebalancer.java > :100644 100644 d815c80... e0c8b6f... M > helix-core/src/test/java/org/apache/helix/integration/TestFullAutoNodeTagging.java > > > Diffs > ----- > > > helix-core/src/main/java/org/apache/helix/controller/rebalancer/AutoRebalancer.java > 3eb258b > > helix-core/src/test/java/org/apache/helix/integration/TestFullAutoNodeTagging.java > d815c80 > > Diff: https://reviews.apache.org/r/14931/diff/ > > > Testing > ------- > > Existing tests pass, new test passes. > > > Thanks, > > Kanak Biscuitwala > >
