----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14728/#review27619 -----------------------------------------------------------
Added a few more comments that came up as I was working on the website for this release. Basically it comes down to: how will these functions that throw UnsupportedOperationExceptions affect existing client workflows? I suppose that users can still get a fully-fledged HelixManager if they want, but we should make it clear in the javadocs and elsewhere what the HelixConnectionAdapter class is for so that we can avoid confusion. helix-core/src/main/java/org/apache/helix/manager/zk/HelixConnectionAdaptor.java <https://reviews.apache.org/r/14728/#comment53650> Should this be a no-op rather than a runtime exception? helix-core/src/main/java/org/apache/helix/manager/zk/HelixConnectionAdaptor.java <https://reviews.apache.org/r/14728/#comment53651> This seems pretty fundamental. Why should it be unsupported? Will this break old clients? helix-core/src/main/java/org/apache/helix/manager/zk/HelixConnectionAdaptor.java <https://reviews.apache.org/r/14728/#comment53652> I would like a way to get a HelixAdmin, especially for people who prefer using it to manage their cluster over the accessors - Kanak Biscuitwala On Oct. 17, 2013, 2:38 p.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14728/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2013, 2:38 p.m.) > > > Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna. > > > Repository: helix-git > > > Description > ------- > > replace HelixManager with HelixConnection so we can reuse connections. major > interfaces are: > > HelixConnection > HelixConnectionStateListener > > HelixService > HelixRole > HelixParticipant > HelixController > HelixAutoController > > AppTest shows an example of using new APIs to setup and start a cluster > > > Diffs > ----- > > helix-core/src/main/java/org/apache/helix/HelixAutoController.java e69de29 > helix-core/src/main/java/org/apache/helix/HelixConnection.java e69de29 > helix-core/src/main/java/org/apache/helix/HelixConnectionStateListener.java > e69de29 > helix-core/src/main/java/org/apache/helix/HelixController.java e69de29 > helix-core/src/main/java/org/apache/helix/HelixParticipant.java e69de29 > helix-core/src/main/java/org/apache/helix/HelixRole.java e69de29 > helix-core/src/main/java/org/apache/helix/HelixService.java e69de29 > > helix-core/src/main/java/org/apache/helix/manager/zk/HelixConnectionAdaptor.java > e69de29 > > helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixAutoController.java > e69de29 > helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixConnection.java > e69de29 > helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixController.java > e69de29 > > helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixLeaderElection.java > e69de29 > > helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixParticipant.java > e69de29 > > helix-core/src/main/java/org/apache/helix/participant/statemachine/HelixStateModelFactory.java > e69de29 > > helix-core/src/main/java/org/apache/helix/participant/statemachine/HelixStateModelFactoryAdaptor.java > e69de29 > helix-core/src/test/java/org/apache/helix/AppTest.java e69de29 > > Diff: https://reviews.apache.org/r/14728/diff/ > > > Testing > ------- > > AppTest > > > Thanks, > > Zhen Zhang > >
