----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14728/#review28253 -----------------------------------------------------------
Great progress.Reviewed only the interfaces. Will review the remaining after getting ur feedback on the review comments helix-core/src/main/java/org/apache/helix/HelixAutoController.java <https://reviews.apache.org/r/14728/#comment54967> Is there a different type of controller, what does autocontroller mean ? helix-core/src/main/java/org/apache/helix/HelixConnection.java <https://reviews.apache.org/r/14728/#comment54968> Can we have an enum defining the state of HelixConnection ?, it can be connected, connecting, disconnected, expired etc. Allows users to use this for additional logic helix-core/src/main/java/org/apache/helix/HelixConnection.java <https://reviews.apache.org/r/14728/#comment54969> createClusterManagment -- Typo calling HelixAdmin createClusterManagementTool lets remove that or deprecate it.Can we not simply call it HelixAdmin ? helix-core/src/main/java/org/apache/helix/HelixConnection.java <https://reviews.apache.org/r/14728/#comment54970> whats the difference between HelixDataAccessor and ParticipantAccessor, ResourceAccessor, ClusterAccessor. Will it be better to get the specificAccessor from HelixDataAccessor ? helix-core/src/main/java/org/apache/helix/HelixConnection.java <https://reviews.apache.org/r/14728/#comment54971> can we get specificAccessor from HelixDataAccessor helix-core/src/main/java/org/apache/helix/HelixConnection.java <https://reviews.apache.org/r/14728/#comment54972> What is HelixRole ? Should we have these addListener methods in the HelixRole ? helix-core/src/main/java/org/apache/helix/HelixRole.java <https://reviews.apache.org/r/14728/#comment54973> why messagingService here ? helix-core/src/main/java/org/apache/helix/HelixService.java <https://reviews.apache.org/r/14728/#comment54974> what does Async mean, how to wait until its started - Kishore Gopalakrishna On Nov. 6, 2013, 1:53 a.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14728/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2013, 1:53 a.m.) > > > Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna. > > > Repository: helix-git > > > Description > ------- > > replace HelixManager with HelixConnection so we can reuse connections. major > interfaces are: > > HelixConnection > HelixConnectionStateListener > > HelixService > HelixRole > HelixParticipant > HelixController > HelixAutoController > > AppTest shows an example of using new APIs to setup and start a cluster > > > Diffs > ----- > > helix-core/src/main/java/org/apache/helix/HelixAutoController.java e69de29 > helix-core/src/main/java/org/apache/helix/HelixConnection.java e69de29 > helix-core/src/main/java/org/apache/helix/HelixConnectionStateListener.java > e69de29 > helix-core/src/main/java/org/apache/helix/HelixController.java e69de29 > helix-core/src/main/java/org/apache/helix/HelixParticipant.java e69de29 > helix-core/src/main/java/org/apache/helix/HelixRole.java e69de29 > helix-core/src/main/java/org/apache/helix/HelixService.java e69de29 > helix-core/src/main/java/org/apache/helix/api/accessor/ClusterAccessor.java > 85b8432 > > helix-core/src/main/java/org/apache/helix/manager/zk/HelixConnectionAdaptor.java > e69de29 > > helix-core/src/main/java/org/apache/helix/manager/zk/ZkBaseDataAccessor.java > 0b112cd > > helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixAutoController.java > e69de29 > helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixConnection.java > e69de29 > helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixController.java > e69de29 > > helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixLeaderElection.java > e69de29 > > helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixParticipant.java > e69de29 > helix-core/src/main/java/org/apache/helix/monitoring/StatusDumpTask.java > e69de29 > > helix-core/src/main/java/org/apache/helix/participant/HelixStateMachineEngine.java > 4e4fdf6 > > helix-core/src/main/java/org/apache/helix/participant/StateMachineEngine.java > d11b3cc > > helix-core/src/main/java/org/apache/helix/participant/statemachine/HelixStateModelFactory.java > e69de29 > > helix-core/src/main/java/org/apache/helix/participant/statemachine/HelixStateModelFactoryAdaptor.java > e69de29 > > helix-core/src/main/java/org/apache/helix/participant/statemachine/StateModelFactory.java > 4d8e598 > > helix-core/src/test/java/org/apache/helix/integration/TestHelixConnection.java > e69de29 > > Diff: https://reviews.apache.org/r/14728/diff/ > > > Testing > ------- > > AppTest > > > Thanks, > > Zhen Zhang > >
