----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16071/#review29860 -----------------------------------------------------------
helix-core/src/main/java/org/apache/helix/controller/stages/MessageSelectionStage.java <https://reviews.apache.org/r/16071/#comment57321> I don't really understand this error message. Can you clarify? helix-core/src/main/java/org/apache/helix/task/TaskRunner.java <https://reviews.apache.org/r/16071/#comment57322> Remove all author tags since Apache doesn't allow them helix-core/src/main/java/org/apache/helix/task/TaskStateModel.java <https://reviews.apache.org/r/16071/#comment57323> Would be nice to have some comment here explaining how exactly this differs from a standard state model helix-core/src/main/java/org/apache/helix/task/TaskUtil.java <https://reviews.apache.org/r/16071/#comment57324> In the code, we've been trying to get away from using string constants and using enums instead. Might want to change this to stay consistent. helix-core/src/main/java/org/apache/helix/task/Workflow.java <https://reviews.apache.org/r/16071/#comment57325> Same as before, enum might be better - Kanak Biscuitwala On Dec. 5, 2013, 5:21 p.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16071/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2013, 5:21 p.m.) > > > Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna. > > > Repository: helix-git > > > Description > ------- > > [HELIX-336] Add support for task framework > > > Diffs > ----- > > helix-core/src/main/java/org/apache/helix/ZNRecord.java 37cd5eb > > helix-core/src/main/java/org/apache/helix/api/accessor/ResourceAccessor.java > b308b98 > > helix-core/src/main/java/org/apache/helix/controller/stages/CurrentStateComputationStage.java > c036b14 > > helix-core/src/main/java/org/apache/helix/controller/stages/ExternalViewComputeStage.java > 7704378 > > helix-core/src/main/java/org/apache/helix/controller/stages/MessageSelectionStage.java > 9adc833 > > helix-core/src/main/java/org/apache/helix/controller/stages/ResourceCurrentState.java > f04afd0 > > helix-core/src/main/java/org/apache/helix/messaging/handling/HelixStateTransitionHandler.java > 8381f4a > > helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskResult.java > 22c4fcd > helix-core/src/main/java/org/apache/helix/model/CurrentState.java 5c9bcbc > > helix-core/src/main/java/org/apache/helix/participant/statemachine/StateModel.java > b88262b > helix-core/src/main/java/org/apache/helix/task/TargetState.java e69de29 > helix-core/src/main/java/org/apache/helix/task/Task.java e69de29 > helix-core/src/main/java/org/apache/helix/task/TaskConfig.java e69de29 > helix-core/src/main/java/org/apache/helix/task/TaskConstants.java e69de29 > helix-core/src/main/java/org/apache/helix/task/TaskContext.java e69de29 > helix-core/src/main/java/org/apache/helix/task/TaskDag.java e69de29 > helix-core/src/main/java/org/apache/helix/task/TaskDriver.java e69de29 > helix-core/src/main/java/org/apache/helix/task/TaskFactory.java e69de29 > helix-core/src/main/java/org/apache/helix/task/TaskPartitionState.java > e69de29 > helix-core/src/main/java/org/apache/helix/task/TaskRebalancer.java e69de29 > helix-core/src/main/java/org/apache/helix/task/TaskResult.java e69de29 > helix-core/src/main/java/org/apache/helix/task/TaskRunner.java e69de29 > helix-core/src/main/java/org/apache/helix/task/TaskState.java e69de29 > helix-core/src/main/java/org/apache/helix/task/TaskStateModel.java e69de29 > helix-core/src/main/java/org/apache/helix/task/TaskStateModelFactory.java > e69de29 > helix-core/src/main/java/org/apache/helix/task/TaskUtil.java e69de29 > helix-core/src/main/java/org/apache/helix/task/Workflow.java e69de29 > helix-core/src/main/java/org/apache/helix/task/WorkflowConfig.java e69de29 > helix-core/src/main/java/org/apache/helix/task/WorkflowContext.java e69de29 > helix-core/src/main/java/org/apache/helix/task/beans/TaskBean.java e69de29 > helix-core/src/main/java/org/apache/helix/task/beans/WorkflowBean.java > e69de29 > helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java 1d02275 > > helix-core/src/main/java/org/apache/helix/tools/StateModelConfigGenerator.java > 8127626 > helix-core/src/test/java/org/apache/helix/TestZNRecord.java 9ff4849 > > helix-core/src/test/java/org/apache/helix/integration/ZkIntegrationTestBase.java > 9188e61 > > helix-core/src/test/java/org/apache/helix/integration/task/TestTaskRebalancer.java > e69de29 > > helix-core/src/test/java/org/apache/helix/integration/task/TestTaskRebalancerStopResume.java > e69de29 > helix-core/src/test/java/org/apache/helix/integration/task/TestUtil.java > e69de29 > > helix-core/src/test/java/org/apache/helix/integration/task/WorkflowGenerator.java > e69de29 > > Diff: https://reviews.apache.org/r/16071/diff/ > > > Testing > ------- > > all tests pass locally > > > Thanks, > > Zhen Zhang > >
