> On Dec. 6, 2013, 1:33 a.m., Kanak Biscuitwala wrote: > > helix-core/src/main/java/org/apache/helix/controller/stages/MessageSelectionStage.java, > > line 114 > > <https://reviews.apache.org/r/16071/diff/1/?file=394827#file394827line114> > > > > I don't really understand this error message. Can you clarify?
in task framework, sometimes we add a resource config but we don't add the resource in ideal-states. fix the log info. > On Dec. 6, 2013, 1:33 a.m., Kanak Biscuitwala wrote: > > helix-core/src/main/java/org/apache/helix/task/TaskRunner.java, line 29 > > <https://reviews.apache.org/r/16071/diff/1/?file=394844#file394844line29> > > > > Remove all author tags since Apache doesn't allow them fixed it. remove both author and version tags > On Dec. 6, 2013, 1:33 a.m., Kanak Biscuitwala wrote: > > helix-core/src/main/java/org/apache/helix/task/TaskUtil.java, line 47 > > <https://reviews.apache.org/r/16071/diff/1/?file=394848#file394848line47> > > > > In the code, we've been trying to get away from using string constants > > and using enums instead. Might want to change this to stay consistent. fixed it > On Dec. 6, 2013, 1:33 a.m., Kanak Biscuitwala wrote: > > helix-core/src/main/java/org/apache/helix/task/Workflow.java, line 42 > > <https://reviews.apache.org/r/16071/diff/1/?file=394849#file394849line42> > > > > Same as before, enum might be better fixed it - Zhen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16071/#review29860 ----------------------------------------------------------- On Dec. 6, 2013, 1:21 a.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16071/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2013, 1:21 a.m.) > > > Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna. > > > Repository: helix-git > > > Description > ------- > > [HELIX-336] Add support for task framework > > > Diffs > ----- > > helix-core/src/main/java/org/apache/helix/ZNRecord.java 37cd5eb > > helix-core/src/main/java/org/apache/helix/api/accessor/ResourceAccessor.java > b308b98 > > helix-core/src/main/java/org/apache/helix/controller/stages/CurrentStateComputationStage.java > c036b14 > > helix-core/src/main/java/org/apache/helix/controller/stages/ExternalViewComputeStage.java > 7704378 > > helix-core/src/main/java/org/apache/helix/controller/stages/MessageSelectionStage.java > 9adc833 > > helix-core/src/main/java/org/apache/helix/controller/stages/ResourceCurrentState.java > f04afd0 > > helix-core/src/main/java/org/apache/helix/messaging/handling/HelixStateTransitionHandler.java > 8381f4a > > helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskResult.java > 22c4fcd > helix-core/src/main/java/org/apache/helix/model/CurrentState.java 5c9bcbc > > helix-core/src/main/java/org/apache/helix/participant/statemachine/StateModel.java > b88262b > helix-core/src/main/java/org/apache/helix/task/TargetState.java e69de29 > helix-core/src/main/java/org/apache/helix/task/Task.java e69de29 > helix-core/src/main/java/org/apache/helix/task/TaskConfig.java e69de29 > helix-core/src/main/java/org/apache/helix/task/TaskConstants.java e69de29 > helix-core/src/main/java/org/apache/helix/task/TaskContext.java e69de29 > helix-core/src/main/java/org/apache/helix/task/TaskDag.java e69de29 > helix-core/src/main/java/org/apache/helix/task/TaskDriver.java e69de29 > helix-core/src/main/java/org/apache/helix/task/TaskFactory.java e69de29 > helix-core/src/main/java/org/apache/helix/task/TaskPartitionState.java > e69de29 > helix-core/src/main/java/org/apache/helix/task/TaskRebalancer.java e69de29 > helix-core/src/main/java/org/apache/helix/task/TaskResult.java e69de29 > helix-core/src/main/java/org/apache/helix/task/TaskRunner.java e69de29 > helix-core/src/main/java/org/apache/helix/task/TaskState.java e69de29 > helix-core/src/main/java/org/apache/helix/task/TaskStateModel.java e69de29 > helix-core/src/main/java/org/apache/helix/task/TaskStateModelFactory.java > e69de29 > helix-core/src/main/java/org/apache/helix/task/TaskUtil.java e69de29 > helix-core/src/main/java/org/apache/helix/task/Workflow.java e69de29 > helix-core/src/main/java/org/apache/helix/task/WorkflowConfig.java e69de29 > helix-core/src/main/java/org/apache/helix/task/WorkflowContext.java e69de29 > helix-core/src/main/java/org/apache/helix/task/beans/TaskBean.java e69de29 > helix-core/src/main/java/org/apache/helix/task/beans/WorkflowBean.java > e69de29 > helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java 1d02275 > > helix-core/src/main/java/org/apache/helix/tools/StateModelConfigGenerator.java > 8127626 > helix-core/src/test/java/org/apache/helix/TestZNRecord.java 9ff4849 > > helix-core/src/test/java/org/apache/helix/integration/ZkIntegrationTestBase.java > 9188e61 > > helix-core/src/test/java/org/apache/helix/integration/task/TestTaskRebalancer.java > e69de29 > > helix-core/src/test/java/org/apache/helix/integration/task/TestTaskRebalancerStopResume.java > e69de29 > helix-core/src/test/java/org/apache/helix/integration/task/TestUtil.java > e69de29 > > helix-core/src/test/java/org/apache/helix/integration/task/WorkflowGenerator.java > e69de29 > > Diff: https://reviews.apache.org/r/16071/diff/ > > > Testing > ------- > > all tests pass locally > > > Thanks, > > Zhen Zhang > >
