[
https://issues.apache.org/jira/browse/HIVE-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019232#comment-13019232
]
jirapos...@reviews.apache.org commented on HIVE-1943:
-----------------------------------------------------
bq. On 2011-04-13 06:21:06, Amareshwari Sriramadasu wrote:
bq. > http://svn.apache.org/repos/asf/hive/trunk/metastore/build.xml, lines
25-46
bq. > <https://reviews.apache.org/r/586/diff/1/?file=15648#file15648line25>
bq. >
bq. > Did not understand why this change is required?
Right. This is not needed (it was needed in an earlier version of the
TestMetaStoreAuthorization).
bq. On 2011-04-13 06:21:06, Amareshwari Sriramadasu wrote:
bq. >
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java,
line 649
bq. > <https://reviews.apache.org/r/586/diff/1/?file=15649#file15649line649>
bq. >
bq. > change Table metadata to databse metadata?
Copy-paste problem :(
bq. On 2011-04-13 06:21:06, Amareshwari Sriramadasu wrote:
bq. >
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java,
line 1399
bq. > <https://reviews.apache.org/r/586/diff/1/?file=15649#file15649line1399>
bq. >
bq. > change Table metadata to partition metadata?
Copy-paste problem :(
bq. On 2011-04-13 06:21:06, Amareshwari Sriramadasu wrote:
bq. >
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java,
line 1411
bq. > <https://reviews.apache.org/r/586/diff/1/?file=15649#file15649line1411>
bq. >
bq. > change Table metadata to partition metadata?
Copy-paste problem :(
bq. On 2011-04-13 06:21:06, Amareshwari Sriramadasu wrote:
bq. >
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java,
lines 63-65
bq. > <https://reviews.apache.org/r/586/diff/1/?file=15652#file15652line63>
bq. >
bq. > Can this be changed to assert statement instead of throwing
exception?
Okay, will make it an assert.
bq. On 2011-04-13 06:21:06, Amareshwari Sriramadasu wrote:
bq. >
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java,
lines 67-69
bq. > <https://reviews.apache.org/r/586/diff/1/?file=15652#file15652line67>
bq. >
bq. > Can this be changed to assert statement instead of throwing
exception?
Okay, will make it an assert.
bq. On 2011-04-13 06:21:06, Amareshwari Sriramadasu wrote:
bq. >
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java,
line 73
bq. > <https://reviews.apache.org/r/586/diff/1/?file=15652#file15652line73>
bq. >
bq. > Can we add the test for group writable also?
That's a bit tricky. The reason being that the test might give out false
positives, since the isWritable call doesn't take any argument to signify for
which entity (owner or group) we are doing the check. For example,
isWritable(foo) will return true for both 570 and 750 permissions on foo. We
really can't say whether the test passed because the check for the owner part
returned true, or, the check for the group part returned true. If i break up
the method isWritable to three methods that do checks on owner, group, and,
others, respectively, i can do the tests for all three, but have a feeling that
that will be an overkill.. Thoughts?
- Devaraj
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/586/#review437
-----------------------------------------------------------
On 2011-04-12 22:12:32, Devaraj Das wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/586/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-04-12 22:12:32)
bq.
bq.
bq. Review request for hive.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is a patch to handle the issue described in HIVE-1943
bq.
bq.
bq. This addresses bug HIVE-1943.
bq. https://issues.apache.org/jira/browse/HIVE-1943
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
1090038
bq. http://svn.apache.org/repos/asf/hive/trunk/conf/hive-default.xml 1090038
bq. http://svn.apache.org/repos/asf/hive/trunk/metastore/build.xml 1090038
bq.
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
1090038
bq.
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
1090038
bq.
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java
1090038
bq.
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java
1090038
bq.
http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20S/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java
1090038
bq.
http://svn.apache.org/repos/asf/hive/trunk/shims/src/common/java/org/apache/hadoop/hive/shims/HadoopShims.java
1090038
bq.
http://svn.apache.org/repos/asf/hive/trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java
1090038
bq.
bq. Diff: https://reviews.apache.org/r/586/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Unit tests added.
bq.
bq.
bq. Thanks,
bq.
bq. Devaraj
bq.
bq.
> Metastore operations (like drop_partition) could be improved in terms of
> maintaining consistency of metadata and data
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-1943
> URL: https://issues.apache.org/jira/browse/HIVE-1943
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Reporter: Devaraj Das
> Assignee: Devaraj Das
>
> Currently, metastore operations with associated hdfs operations like
> drop_partition doesn't do a rollback if the hdfs operation fails. The
> metastore first updates the metadata, and then tries to do hdfs operation. If
> the hdfs operation fails for any reason, the data on the hdfs will be
> orphaned. We should improve the situation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
