[
https://issues.apache.org/jira/browse/HIVE-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019646#comment-13019646
]
jirapos...@reviews.apache.org commented on HIVE-1943:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/586/
-----------------------------------------------------------
(Updated 2011-04-14 00:57:35.688239)
Review request for hive.
Changes
-------
The new patch addresses Amareshwari's comments. The testcase is modified to do
checks for write permissions for everyone in this patch (that will avoid the
confusion that was created in the earlier patch where i was checking the owner
write permissions only).
Summary
-------
This is a patch to handle the issue described in HIVE-1943
This addresses bug HIVE-1943.
https://issues.apache.org/jira/browse/HIVE-1943
Diffs (updated)
-----
http://svn.apache.org/repos/asf/hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
1091578
http://svn.apache.org/repos/asf/hive/trunk/conf/hive-default.xml 1091578
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
1091578
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
1091578
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java
1091578
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java
PRE-CREATION
http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java
1091578
http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20S/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java
1091578
http://svn.apache.org/repos/asf/hive/trunk/shims/src/common/java/org/apache/hadoop/hive/shims/HadoopShims.java
1091578
http://svn.apache.org/repos/asf/hive/trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java
1091578
Diff: https://reviews.apache.org/r/586/diff
Testing
-------
Unit tests added.
Thanks,
Devaraj
> Metastore operations (like drop_partition) could be improved in terms of
> maintaining consistency of metadata and data
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-1943
> URL: https://issues.apache.org/jira/browse/HIVE-1943
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Reporter: Devaraj Das
> Assignee: Devaraj Das
>
> Currently, metastore operations with associated hdfs operations like
> drop_partition doesn't do a rollback if the hdfs operation fails. The
> metastore first updates the metadata, and then tries to do hdfs operation. If
> the hdfs operation fails for any reason, the data on the hdfs will be
> orphaned. We should improve the situation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
