[ https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021190#comment-13021190 ]
jirapos...@reviews.apache.org commented on HIVE-1644: ----------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/558/#review495 ----------------------------------------------------------- ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcessor.java <https://reviews.apache.org/r/558/#comment1027> Oh, and reading your original comment more carefully: yeah, they are two separate entities (one for the table partition, and one for the index partition), so even if the equals method were tied to metastore object identity, it still wouldn't work. The getSpec() method on the Partition class is what gives you the actual key/value pairs for the partition, suitable for comparison. - John On 2011-04-16 06:04:26, Russell Melick wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/558/ bq. ----------------------------------------------------------- bq. bq. (Updated 2011-04-16 06:04:26) bq. bq. bq. Review request for hive. bq. bq. bq. Summary bq. ------- bq. bq. Review request for HIVE-1644.12.patch bq. bq. bq. This addresses bug HIVE-1644. bq. https://issues.apache.org/jira/browse/HIVE-1644 bq. bq. bq. Diffs bq. ----- bq. bq. common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a21f589 bq. conf/hive-default.xml c42197f bq. ql/src/java/org/apache/hadoop/hive/ql/Driver.java 14015d0 bq. ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java 6437385 bq. ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java c02d90b bq. ql/src/java/org/apache/hadoop/hive/ql/index/AbstractIndexHandler.java dd0186d bq. ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexHandler.java 411b78f bq. ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexQueryContext.java PRE-CREATION bq. ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java 1f01446 bq. ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 50db44c bq. ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRTableScan1.java 6162676 bq. ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/IndexWhereResolver.java PRE-CREATION bq. ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/PhysicalOptimizer.java 0ae9fa2 bq. ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcCtx.java PRE-CREATION bq. ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcessor.java PRE-CREATION bq. ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereTaskDispatcher.java PRE-CREATION bq. ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 937a7b3 bq. ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java f0aca84 bq. ql/src/java/org/apache/hadoop/hive/ql/plan/MapredWork.java 73391e9 bq. ql/src/test/queries/clientpositive/index_auto.q PRE-CREATION bq. ql/src/test/queries/clientpositive/index_auto_file_format.q PRE-CREATION bq. ql/src/test/queries/clientpositive/index_auto_multiple.q PRE-CREATION bq. ql/src/test/queries/clientpositive/index_auto_partitioned.q PRE-CREATION bq. ql/src/test/queries/clientpositive/index_auto_unused.q PRE-CREATION bq. ql/src/test/results/clientpositive/index_auto.q.out PRE-CREATION bq. ql/src/test/results/clientpositive/index_auto_file_format.q.out PRE-CREATION bq. ql/src/test/results/clientpositive/index_auto_multiple.q.out PRE-CREATION bq. ql/src/test/results/clientpositive/index_auto_partitioned.q.out PRE-CREATION bq. ql/src/test/results/clientpositive/index_auto_unused.q.out PRE-CREATION bq. ql/src/test/results/clientpositive/index_opt_where.q.out PRE-CREATION bq. ql/src/test/results/clientpositive/index_opt_where_partitioned.q.out PRE-CREATION bq. ql/src/test/results/clientpositive/index_opt_where_simple.q.out PRE-CREATION bq. bq. Diff: https://reviews.apache.org/r/558/diff bq. bq. bq. Testing bq. ------- bq. bq. bq. Thanks, bq. bq. Russell bq. bq. > use filter pushdown for automatically accessing indexes > ------------------------------------------------------- > > Key: HIVE-1644 > URL: https://issues.apache.org/jira/browse/HIVE-1644 > Project: Hive > Issue Type: Improvement > Components: Indexing > Affects Versions: 0.8.0 > Reporter: John Sichi > Assignee: Russell Melick > Attachments: HIVE-1644.1.patch, HIVE-1644.10.patch, > HIVE-1644.11.patch, HIVE-1644.12.patch, HIVE-1644.13.patch, > HIVE-1644.14.patch, HIVE-1644.2.patch, HIVE-1644.3.patch, HIVE-1644.4.patch, > HIVE-1644.5.patch, HIVE-1644.6.patch, HIVE-1644.7.patch, HIVE-1644.8.patch, > HIVE-1644.9.patch > > > HIVE-1226 provides utilities for analyzing filters which have been pushed > down to a table scan. The next step is to use these for selecting available > indexes and generating access plans for those indexes. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira