[ 
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026790#comment-13026790
 ] 

jirapos...@reviews.apache.org commented on HIVE-1644:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/558/#review610
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcessor.java
<https://reviews.apache.org/r/558/#comment1253>

    This does not work because the GenMRTableScan1.process() does not get 
called on these objects after we set these, as far as I can tell.



ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcessor.java
<https://reviews.apache.org/r/558/#comment1254>

    At this point, the inputFormat for this work is actually null.  I do not 
know which work I need to change the inputFormat for, and I can't think of an 
easy way to get to other work.


- Russell


On 2011-04-29 00:01:06, Russell Melick wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/558/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-04-29 00:01:06)
bq.  
bq.  
bq.  Review request for hive.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Review request for HIVE-1644.12.patch
bq.  
bq.  
bq.  This addresses bug HIVE-1644.
bq.      https://issues.apache.org/jira/browse/HIVE-1644
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    common/src/java/org/apache/hadoop/hive/conf/HiveConf.java f77f46c 
bq.    conf/hive-default.xml 6bd615e 
bq.    eclipse-templates/.classpath 8d2dc52 
bq.    ql/src/java/org/apache/hadoop/hive/ql/Driver.java ca337a8 
bq.    ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java 24e16e4 
bq.    ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java 
c02d90b 
bq.    ql/src/java/org/apache/hadoop/hive/ql/index/AbstractIndexHandler.java 
dd0186d 
bq.    ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexHandler.java 
411b78f 
bq.    ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexQueryContext.java 
PRE-CREATION 
bq.    
ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java 
f90d64f 
bq.    ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 50db44c 
bq.    ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRTableScan1.java 
6162676 
bq.    
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/IndexWhereResolver.java
 PRE-CREATION 
bq.    
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/PhysicalOptimizer.java 
0ae9fa2 
bq.    
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcCtx.java
 PRE-CREATION 
bq.    
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcessor.java
 PRE-CREATION 
bq.    
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereTaskDispatcher.java
 PRE-CREATION 
bq.    ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 374e123 
bq.    ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
2207ac4 
bq.    ql/src/java/org/apache/hadoop/hive/ql/plan/MapredWork.java 73391e9 
bq.    ql/src/test/queries/clientpositive/index_auto.q PRE-CREATION 
bq.    ql/src/test/queries/clientpositive/index_auto_file_format.q PRE-CREATION 
bq.    ql/src/test/queries/clientpositive/index_auto_multiple.q PRE-CREATION 
bq.    ql/src/test/queries/clientpositive/index_auto_partitioned.q PRE-CREATION 
bq.    ql/src/test/queries/clientpositive/index_auto_test_if_used.q 
PRE-CREATION 
bq.    ql/src/test/queries/clientpositive/index_auto_unused.q PRE-CREATION 
bq.    ql/src/test/results/clientpositive/index_auto.q.out PRE-CREATION 
bq.    ql/src/test/results/clientpositive/index_auto_file_format.q.out 
PRE-CREATION 
bq.    ql/src/test/results/clientpositive/index_auto_multiple.q.out 
PRE-CREATION 
bq.    ql/src/test/results/clientpositive/index_auto_partitioned.q.out 
PRE-CREATION 
bq.    ql/src/test/results/clientpositive/index_auto_test_if_used.q.out 
PRE-CREATION 
bq.    ql/src/test/results/clientpositive/index_auto_unused.q.out PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/558/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Russell
bq.  
bq.



> use filter pushdown for automatically accessing indexes
> -------------------------------------------------------
>
>                 Key: HIVE-1644
>                 URL: https://issues.apache.org/jira/browse/HIVE-1644
>             Project: Hive
>          Issue Type: Improvement
>          Components: Indexing
>    Affects Versions: 0.8.0
>            Reporter: John Sichi
>            Assignee: Russell Melick
>         Attachments: HIVE-1644.1.patch, HIVE-1644.10.patch, 
> HIVE-1644.11.patch, HIVE-1644.12.patch, HIVE-1644.13.patch, 
> HIVE-1644.14.patch, HIVE-1644.15.patch, HIVE-1644.16.patch, 
> HIVE-1644.2.patch, HIVE-1644.3.patch, HIVE-1644.4.patch, HIVE-1644.5.patch, 
> HIVE-1644.6.patch, HIVE-1644.7.patch, HIVE-1644.8.patch, HIVE-1644.9.patch
>
>
> HIVE-1226 provides utilities for analyzing filters which have been pushed 
> down to a table scan.  The next step is to use these for selecting available 
> indexes and generating access plans for those indexes.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to