----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/958/ -----------------------------------------------------------
Review request for hive and Carl Steinbach. Summary ------- This patch updates HiveServer and HiveMetastore to add proper cli handling - similar to that used in CliDriver (ie GnuParser). There's a common HiveCli class that's used by both main classes. I've attempted to make the cli's backward compatible with the prior command line processing. Notice I've "deprecated" (via warnings, but the code still runs) if the old style CLI usage is used. commands such as the following now work as expected: bin/hive --service hiveserver -t 200 -p 12000 --hiveconf hive.root.logger=DEBUG,console as does the following which generates usage information: bin/hive --service hiveserver -h Note: HiveMetastore as not initializing log4j, I updated the code to do similar to HiveServer (otw the hiveconf hive.root.logger option above didn't work). This addresses bug HIVE-2139. https://issues.apache.org/jira/browse/HIVE-2139 Diffs ----- bin/ext/hiveserver.sh b5edce4 bin/ext/metastore.sh db15f6e common/src/java/org/apache/hadoop/hive/common/cli/HiveCli.java PRE-CREATION metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java bc58bd5 service/src/java/org/apache/hadoop/hive/service/HiveServer.java ea04be9 Diff: https://reviews.apache.org/r/958/diff Testing ------- I couldn't find any tests for these changes, so I verfied the changes manually. Thanks, Patrick