----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/958/ -----------------------------------------------------------
(Updated 2011-07-19 20:15:07.278811) Review request for hive and Carl Steinbach. Changes ------- Updated with Carl's comments. Summary ------- This patch updates HiveServer and HiveMetastore to add proper cli handling - similar to that used in CliDriver (ie GnuParser). There's a common HiveCli class that's used by both main classes. I've attempted to make the cli's backward compatible with the prior command line processing. Notice I've "deprecated" (via warnings, but the code still runs) if the old style CLI usage is used. commands such as the following now work as expected: bin/hive --service hiveserver -t 200 -p 12000 --hiveconf hive.root.logger=DEBUG,console as does the following which generates usage information: bin/hive --service hiveserver -h Note: HiveMetastore as not initializing log4j, I updated the code to do similar to HiveServer (otw the hiveconf hive.root.logger option above didn't work). This addresses bug HIVE-2139. https://issues.apache.org/jira/browse/HIVE-2139 Diffs (updated) ----- common/build.xml 0969e16 common/ivy.xml bee3bf0 common/src/java/org/apache/hadoop/hive/common/LogUtils.java PRE-CREATION common/src/java/org/apache/hadoop/hive/common/cli/CommonCliOptions.java PRE-CREATION hwi/src/java/org/apache/hadoop/hive/hwi/HWISessionItem.java 1bf8c97 metastore/ivy.xml 83218fc metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java e540c63 ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java 090ecfc ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 61393c8 ql/src/test/org/apache/hadoop/hive/ql/history/TestHiveHistory.java 728958d service/src/java/org/apache/hadoop/hive/service/HiveServer.java ea04be9 cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java bd9f6b1 bin/ext/hiveserver.sh b5edce4 bin/ext/metastore.sh db15f6e Diff: https://reviews.apache.org/r/958/diff Testing ------- I couldn't find any tests for these changes, so I verfied the changes manually. Thanks, Patrick