----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1137/#review1107 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/index/bitmap/BitmapIndexHandler.java <https://reviews.apache.org/r/1137/#comment2246> Two comments on this fix: 1) I think we need a helper method, since we've started using Driver.compile for reentrant SQL in a few places (there's actually another call both here and in CompactIndexHandler, and one more in DDLSemanticAnalyzer). 2) While we're at it, we can make the helper method save/restore any other statement-specific state (command string?). - John On 2011-07-15 22:33:48, Syed Albiz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1137/ > ----------------------------------------------------------- > > (Updated 2011-07-15 22:33:48) > > > Review request for hive, John Sichi and Ning Zhang. > > > Summary > ------- > > Save the original HiveOperation/commandType when we generate the index > builder task and restore it after we're done generating the task so that the > authorization checks make the right decision when deciding what to do. > > > This addresses bug HIVE-2286. > https://issues.apache.org/jira/browse/HIVE-2286 > > > Diffs > ----- > > ql/src/test/results/clientpositive/index_auth.q.out PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/index/bitmap/BitmapIndexHandler.java > 61bbbf5 > > ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java > 7c91946 > ql/src/test/queries/clientpositive/index_auth.q PRE-CREATION > > Diff: https://reviews.apache.org/r/1137/diff > > > Testing > ------- > > Added new testcase to TestCliDriver: index_auth.q > > > Thanks, > > Syed > >
