----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1137/#review1188 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/Driver.java <https://reviews.apache.org/r/1137/#comment2597> java.util.Stack is deprecated since it adds unnecessary synchronization. We don't have a replacement yet (HIVE-1626) so we've just been using ArrayList. Also, instead of typecasting to/from Object, use a static inner class for holding the record of state variables. - John On 2011-07-25 23:03:22, Syed Albiz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1137/ > ----------------------------------------------------------- > > (Updated 2011-07-25 23:03:22) > > > Review request for hive, John Sichi and Ning Zhang. > > > Summary > ------- > > Save the original HiveOperation/commandType when we generate the index > builder task and restore it after we're done generating the task so that the > authorization checks make the right decision when deciding what to do. > > > This addresses bug HIVE-2286. > https://issues.apache.org/jira/browse/HIVE-2286 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java b278ffe > ql/src/test/queries/clientpositive/index_auth.q PRE-CREATION > ql/src/test/results/clientnegative/index_compact_entry_limit.q.out fcb2673 > ql/src/test/results/clientnegative/index_compact_size_limit.q.out fcb2673 > ql/src/test/results/clientpositive/index_auth.q.out PRE-CREATION > ql/src/test/results/clientpositive/index_auto.q.out 8d65f98 > ql/src/test/results/clientpositive/index_auto_file_format.q.out 194b35e > ql/src/test/results/clientpositive/index_auto_multiple.q.out 6b81fc3 > ql/src/test/results/clientpositive/index_auto_partitioned.q.out b0635db > ql/src/test/results/clientpositive/index_auto_unused.q.out 3631bbc > ql/src/test/results/clientpositive/index_bitmap.q.out 8f41ce3 > ql/src/test/results/clientpositive/index_bitmap1.q.out 9f638f5 > ql/src/test/results/clientpositive/index_bitmap2.q.out e901477 > ql/src/test/results/clientpositive/index_bitmap3.q.out 116c973 > ql/src/test/results/clientpositive/index_bitmap_auto.q.out cc9d91e > ql/src/test/results/clientpositive/index_bitmap_auto_partitioned.q.out > 9003eb4 > ql/src/test/results/clientpositive/index_bitmap_rc.q.out 9bd3c98 > ql/src/test/results/clientpositive/index_compact.q.out c339ec9 > ql/src/test/results/clientpositive/index_compact_1.q.out 34ba3ca > ql/src/test/results/clientpositive/index_compact_2.q.out e8ce238 > ql/src/test/results/clientpositive/index_compact_3.q.out d39556d > ql/src/test/results/clientpositive/index_creation.q.out 532f07e > > Diff: https://reviews.apache.org/r/1137/diff > > > Testing > ------- > > Added new testcase to TestCliDriver: index_auth.q > > > Thanks, > > Syed > >
