> On Feb. 12, 2015, 8:42 a.m., Mohit Sabharwal wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/Deadline.java, line 45 > > <https://reviews.apache.org/r/29807/diff/4/?file=838557#file838557line45> > > > > Why do we need to store the method name of the HMS method we are timing > > ? Is it just so we can print it in the exception message ? > > > > Instead of storing it here, maybe we can log the method name when the > > DeadlineException is caught in HMS ?
It is a good idea to log the method name when the DeadlineException is caught in HMS. I added it in new patch. How about we still keep the method name in the exception message? Since after logging the exception, it is re-thrown. Maybe upper caller or client side want to know the method info from the exception. > On Feb. 12, 2015, 8:42 a.m., Mohit Sabharwal wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/Deadline.java, line 110 > > <https://reviews.apache.org/r/29807/diff/4/?file=838557#file838557line110> > > > > do we really need to record the method ? As discussed above, if client side want to know method info from the exception, this maybe need to be record. - Dong ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29807/#review72119 ----------------------------------------------------------- On Jan. 28, 2015, 8:58 a.m., Dong Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29807/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2015, 8:58 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-9253: MetaStore server should support timeout for long running requests > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 66f436b > metastore/src/java/org/apache/hadoop/hive/metastore/Deadline.java > PRE-CREATION > metastore/src/java/org/apache/hadoop/hive/metastore/DeadlineException.java > PRE-CREATION > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > fc6f067 > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 574141c > metastore/src/java/org/apache/hadoop/hive/metastore/RetryingHMSHandler.java > 01ad36a > > metastore/src/java/org/apache/hadoop/hive/metastore/SessionPropertiesListener.java > PRE-CREATION > metastore/src/test/org/apache/hadoop/hive/metastore/TestDeadline.java > PRE-CREATION > > metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTimeout.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/29807/diff/ > > > Testing > ------- > > UT passed > > > Thanks, > > Dong Chen > >
