----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29807/#review74365 -----------------------------------------------------------
This looks great to me! We can do the check in more places in a follow-on jira. I just had one thought about the property name and then I think let's commit! Nice work Dong!! common/src/java/org/apache/hadoop/hive/conf/HiveConf.java <https://reviews.apache.org/r/29807/#comment120931> I don't feel it makes any sense to have a smaller "long running timeout" than hive.metastore.client.socket.timeout or any larger. Thus as opposed to creating a new config I feel like we should re-use hive.metastore.client.socket.timeout. - Brock Noland On Feb. 26, 2015, 8:51 a.m., Dong Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29807/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2015, 8:51 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-9253: MetaStore server should support timeout for long running requests > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8e072f7 > metastore/src/java/org/apache/hadoop/hive/metastore/Deadline.java > PRE-CREATION > metastore/src/java/org/apache/hadoop/hive/metastore/DeadlineException.java > PRE-CREATION > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > ab011fc > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 574141c > metastore/src/java/org/apache/hadoop/hive/metastore/RetryingHMSHandler.java > 01ad36a > > metastore/src/java/org/apache/hadoop/hive/metastore/SessionPropertiesListener.java > PRE-CREATION > metastore/src/test/org/apache/hadoop/hive/metastore/TestDeadline.java > PRE-CREATION > > metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTimeout.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/29807/diff/ > > > Testing > ------- > > UT passed > > > Thanks, > > Dong Chen > >
